Skip to content

Fix braced-scalar-init, shadowing and unused variables in tests #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jordan08 wants to merge 1 commit into
base: codac2
Choose a base branch
from
Open

Fix braced-scalar-init, shadowing and unused variables in tests #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/manual/manual/tubes/src.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,9 @@ TEST_CASE("SlicedTube class - manual")
Interval y(0,0.2);
x.invert(y, v_t);

for(const auto& t : v_t)
for(const auto& ti : v_t)
{
IntervalVector z = cart_prod(t,y);
IntervalVector z = cart_prod(ti,y);
DefaultFigure::draw_box(z, Color::red());
}
// [slicedtube-class-5-end]
Expand Down
12 changes: 6 additions & 6 deletions tests/core/domains/interval/codac2_tests_IntervalMatrix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,8 +505,8 @@ TEST_CASE("IntervalMatrix - mixing type")
{
{
Matrix m1 {
{ {1},{2} },
{ {3},{4} }
{ 1,2 },
{ 3,4 }
};

// Interval - Matrix
Expand Down Expand Up @@ -611,13 +611,13 @@ TEST_CASE("IntervalMatrix - mixing type")

{
Matrix m1 {
{ {1},{2} },
{ {3},{4} }
{ 1,2 },
{ 3,4 }
};

Matrix m2 {
{ {2},{3} },
{ {4},{5} }
{ 2,3 },
{ 4,5 }
};

IntervalMatrix im(m1,m2);
Expand Down
6 changes: 3 additions & 3 deletions tests/core/domains/interval/codac2_tests_IntervalVector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,9 +638,9 @@ TEST_CASE("IntervalVector")

{
IntervalVector a{Interval::empty(),{-1,1}};
IntervalVector b{{-1,1},Interval::empty()};
IntervalVector c = a | b;
CHECK(c.is_empty());
IntervalVector b2{{-1,1},Interval::empty()};
IntervalVector c2 = a | b2;
CHECK(c2.is_empty());
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/core/domains/tube/codac2_tests_predefined_tubes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ SlicedTube<Interval> tube_test4()

x.set({1,2}, {0,9});
x.set({0.5,1.5}, {9,11});
x.set({-1,1}, {10.2}); // degenerate time interval
x.set({-1,1}, Interval(10.2)); // degenerate time interval
x.set({-1.5,-0.5}, {11,12});
x.set({-1,1}, {12,13});
x.set({0.5,1.5}, {13,14});
Expand Down
4 changes: 2 additions & 2 deletions tests/core/operators/codac2_tests_operators.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
using namespace std;
using namespace codac2;

const double MAX_DOUBLE = std::numeric_limits<double>::max();
//const double MAX_DOUBLE = std::numeric_limits<double>::max();

void CHECK_bwd_trigo(const Interval& y, const Interval& x, const Interval& expected_x)
{
Expand Down Expand Up @@ -475,4 +475,4 @@ TEST_CASE("Interval bwd modulo")
ModOp::bwd({0.1,0.2}, x, p);
CHECK(x == Interval::empty());
CHECK(p == Interval::empty());
}
}
Loading