Fix community Leading Teachers country filter and avatar placeholders - #3650
Merged
Merged
Conversation
Filter approved teachers by the selected country so Lithuania (and others) are not buried in the full EU list, and fall back to a local default image when S3 avatars are missing or inaccessible. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
country_iso(same pattern as ambassadors), so country pages like Lithuania only show that country's teachers.images/default.pngwhen the stored avatar is empty, a known default, or fails to load from S3.@jsonto avoid JS breakage from special characters in names/paths.Test plan
/community?country_iso=LTand confirm only Lithuanian Leading Teachers appear in the map sidebar (~16), with markers for their cities.php artisan test --filter=UserCommunityAvatarUrlTestMade with Cursor