chore: replace PRLint with Carson's pr-title-linter - #10529
Open
paulbalandan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR starts moving our repository automation onto a single GitHub App, Carson, installed once at the org level and driven from
.github/carson.yml. Each existing app or action gets its own PR so the translation can be checked in isolation.First up is PRLint. Its one rule ports verbatim into Carson's
pr-title-lintersubscriber: same regex, same message. The result is reported as a check run instead of thePRLintReloadedstatus. The check is currently namedCarson / pr-titlevia thenamesetting in.github/carson.ymland can be renamed to anything before merge, for example to match the App name chosen below.Changes:
.github/carson.ymlenablingpr-title-linterwith the existing title rule..github/workflows/carson.ymlrunning Carson onpull_request_targetforopenedandedited, pinned to v1.3.0. Triggers are limited to what this subscriber needs and will widen as more subscribers come over..github/prlint.json.Why Carson:
pull_request_targetis safe here.Before merging, an org admin needs to:
codeigniter4org via https://nexusphp.github.io/carson/ and install it on this repository. The name is the admin's call. GitHub App names must be unique across GitHub, and the name determines the bot login that appears on comments and check runs. Some options:Carson @ CodeIgniter4(bot:carson-codeigniter4[bot]), matching the org loginCarson @ CodeIgniter(bot:carson-codeigniter[bot]), matching the project nameCodeIgniter Butler(bot:codeigniter-butler[bot]), if we prefer not to expose the tool namecodeigniter4-bot(bot:codeigniter4-bot[bot]), a plain org-branded bot accountcodeigniter-bot(bot:codeigniter-bot[bot]), the same without the version numberCARSON_APP_IDandCARSON_PRIVATE_KEYas Actions secrets.PRLintReloadedwith the check name from.github/carson.ymlin any required status check rule.Because the workflow runs from the base branch under
pull_request_target, the check will first appear on PRs opened after this merges.Planned follow-ups, in order:
auto-labelerplusconflicts-notifier(replacingactions/labelerand the conflict script),signed-commits, and finallywelcomeplustemplate-enforcerfor Mergeable.Test runs can be checked here: https://github.com/paulbalandan/b40d520f57f086f2e58d1f21d093935d/actions
Checklist: