Write --write-changes via a tempfile so interrupts cannot empty files - #4028
Merged
larsoner merged 2 commits intoSep 21, 2026
Merged
Conversation
open(..., "w") truncates the target before the new contents are written, so a kill, full disk, or failed write leaves the original file at 0 bytes. Write to a same-directory tempfile, copy the original mode, then os.replace so a failed update keeps the old text. Fixes codespell-project#4025
Member
|
Just a tiny tweak to use |
larsoner
enabled auto-merge (squash)
September 21, 2026 16:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4025
--write-changescurrently opens the target with"w", which truncates it before the corrected text is written. If the process is killed, the disk is full, or the write fails after thatopen, the original file is left at 0 bytes.This writes to a same-directory tempfile and
os.replaces it over the original, so a failed update keeps the previous contents. The original file mode is copied onto the tempfile before the replace.Tests cover a failed
os.replace(original text remains, leftover tempfiles are removed) and preservation of POSIX permission bits.