Skip to content

fix: use spdx license classifier - #67

Merged
cottsay merged 1 commit into
colcon:masterfrom
IamPhytan:fix/spdx-license
Sep 25, 2026
Merged

cottsay merged 1 commit into
colcon:masterfrom
IamPhytan:fix/spdx-license

Conversation

@IamPhytan

Copy link
Copy Markdown
Contributor

When running building the sources with the developer instructions, I receive this error message:

--- stderr: colcon-python-setup-py                                                                          
/home/damien/code/ros/colcon/.venv/lib/python3.14/site-packages/setuptools/dist.py:759: SetuptoolsDep
recationWarning: License classifiers are deprecated.
!!

        ********************************************************************************
        Please consider removing the following classifiers in favor of a SPDX license expression:

        License :: OSI Approved :: Apache Software License

        See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details
.
        ********************************************************************************

!!
  self._finalize_license_expression()
---

Changed the license specifier, like in colcon-output.

@codecov-commenter

codecov-commenter commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.00%. Comparing base (45d0a04) to head (8f657a1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   51.00%   51.00%           
=======================================
  Files           3        3           
  Lines         149      149           
  Branches       23       23           
=======================================
  Hits           76       76           
  Misses         67       67           
  Partials        6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cottsay
cottsay merged commit 2317cc9 into colcon:master Sep 25, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants