fix: make spectator camera dependency self-contained - #284
Closed
mythzilla-coder wants to merge 79 commits into
Closed
mythzilla-coder wants to merge 79 commits into
mythzilla-coder wants to merge 79 commits into
Conversation
added 30 commits
August 31, 2026 08:24
added 27 commits
September 3, 2026 05:50
Contributor
|
Sorry, I'll need some sort of explanation of what this is and what it adds. Is this is a spectator camera gamemode, I believe that there are already mods that achieve this with much less code bloat. |
Author
|
Thanks for taking a look. Your concern about the size of the change is fair.
What we're working on is broader than a simple spectator-camera mod.
The goal is an autonomous AI-vs-AI spectator mode that can run
continuous matches by itself, handle scoring/resetting, select and
attribute important combat events, move the camera toward those
events, and eventually serve as a stable spectator/livestream mode.
A lot of the code currently visible in this PR is diagnostic and
experimental infrastructure that accumulated while we were
investigating engine behavior — for example actor lifecycle/death
attribution, camera timing, telemetry, and runtime verification. That
makes the PR much larger than the actual production feature should be.
In hindsight, we opened the PR too early and then used the branch as
an active R&D workspace. That's not a good fit for upstream review,
and I don't want to burden the project with a large experimental diff.
I'm going to close this PR and continue the work privately. If we
later identify a small, self-contained improvement that genuinely
belongs upstream, I'll come back with a much cleaner and more focused
contribution.
Thanks for the feedback — it helped clarify that distinction.
…On Sun, 13 Sep 2026 15:10:57 -0700, Causeless ***@***.***> wrote:
Causeless left a comment [(cortex-command-community/Cortex-Command-Community-Project#284)](#284 (comment))
Sorry, I'll need some sort of explanation of what this is and what it adds. Is this is a spectator camera gamemode, I believe that there are already mods that achieve this with much less code bloat.
—
Reply to this email directly, [view it on GitHub](#284?email_source=notifications&email_token=COMEDIPDAYEVEVS2RJOAOWD5O4LPDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRVGY2TAMZSGQYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5656503240), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/COMEDIK27VNADWLPJMBHSQD5O4LPDAVCNFSNUABFKJSXA33TNF2G64TZHM3TGNZZGI3TSOBZHNEXG43VMU5TKNBUGA4DINRWGAYKC5QC).
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for [iOS](https://github.com/notifications/mobile/ios/COMEDIN4DQTOKD6IZJR4QTD5O4LPDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRVGY2TAMZSGQYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG) and [Android](https://github.com/notifications/mobile/android/COMEDIKJB5XB3VEVMOSBJUD5O4LPDA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRVGY2TAMZSGQYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA). Download it today!
You are receiving this because you authored the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Review status
Camera behavior is intentionally not accepted yet: native rendered-frame review could not be completed because the native computer-use surface exposed no game window. See
docs/SPECTATOR_CAMERA_ACCEPTANCE_2026-09-13.md.