Skip to content

Update rollout operator usage - #673

Merged
kd7lxl merged 4 commits into
cortexproject:masterfrom
timonegk:update-rollout-operator
Oct 7, 2026
Merged

kd7lxl merged 4 commits into
cortexproject:masterfrom
timonegk:update-rollout-operator

Conversation

@timonegk

Copy link
Copy Markdown
Contributor

What this PR does:
Follow-up on #668. These are some fixes regarding the rollout operator.

  • set the alias in Chart.yaml so that users can set custom values
  • CRDs are required to run the operator, so this adds installation instructions for them and drops disabling the CRDs
  • Set the security context on the rollout operator (same values as used by Grafana)

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX], [DEPENDENCY]

@timonegk
timonegk force-pushed the update-rollout-operator branch 3 times, most recently from d120de4 to 76571c1 Compare September 25, 2026 14:01
@timonegk
timonegk force-pushed the update-rollout-operator branch from af69b10 to d2fecb8 Compare September 28, 2026 07:41
@nschad
nschad requested a review from kd7lxl September 29, 2026 08:25
Signed-off-by: Timon Engelke <timon.engelke@inovex.de>
Signed-off-by: Timon Engelke <timon.engelke@inovex.de>
Signed-off-by: Timon Engelke <timon.engelke@inovex.de>
Signed-off-by: Timon Engelke <timon.engelke@inovex.de>
@timonegk

Copy link
Copy Markdown
Contributor Author

rebased

@timonegk
timonegk force-pushed the update-rollout-operator branch from 74ee8c0 to eaa3ef0 Compare September 29, 2026 13:15
It is sufficient to set these settings on the querier using `querier.extraArgs`. Set `distributor.sharding-strategy` to `default` and `distributor.shard-by-all-labels` to `"true"` there.
Warning: This may increase resource usage of the queriers.

To get the rollout-operator running, you will have to install its CRDs. Due to Helm's CRD handling, you have to apply [these manifests](https://github.com/grafana/helm-charts/tree/main/charts/rollout-operator/charts/crds/crds) manually

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to see instructions for deploying rollout-operator independently. This way helm can install the CRDs. An operator in a subchart is messy because of this CRDs issue, and also because you generally only want one, while you may have several cortex instances in a cluster. Without instructions for a standalone rollout-operator installation, users are left to choose which instance of cortex they want to own rollout-operator.

@kd7lxl
kd7lxl merged commit e6fe59f into cortexproject:master Oct 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants