Repository navigation
Enable tidy-review and format-review for draft PRs #270
Description
Activity
Perhaps I missed somethings but it looks like tidy-review and format-review are not supported in draft PRs.
This was intentional. The tidy-review feature is still a bit experimental from our end. And,
format-reviewis less complicated to implement.I would say you missed this if you didn't read our documented PR review caveats.
This actually marks the second request to allow drafted PRs to be reviewed by cpp-linter. Maybe I should expose this capability via an env var (
CPP_LINTER_REVIEW_DRAFTS=1perhaps).I'd be more confident in these features if I could devise a way to reduce duplicate suggestions...
Reacted by Ralf KonradI would say you missed this if you didn't read our documented PR review caveats.
True, sorry for that. I only searched in Inputs and Outputs for "draft".
And thanks for your quick answer. I guess it might be enough for the time being to look at the
thread-commentsandfile-annotationsto resolve any issue "manually". Normally, forclang-formatit is the forgotten formatting before saving in the IDE anyhow.Feel free to close this feature request or keep it open for others as reference.
I'll close it as "unplanned" and pin it for visibility. People that want this feature can add a 👍. This thread will not be locked either, so anyone with additional context can post it here.
Reacted by Ralf Konrad- pinned this issue
on Oct 4, 2024
Is your idea related to an existing feature?
tidy-review, format-review
Describe the behavior you would like
Perhaps I missed somethings but it looks like
tidy-reviewandformat-revieware not supported in draft PRs. At least, there are no code reviews available in a draft PR even with the features enabled.We are using drafts a lot for early reviews and the other obvious reasons, so it would be good to be able to incorporate the suggested changes already at that stage.
Describe alternatives you have considered
No response
Additional context
Otherwise, it's really good action. Thanks for the effort!