Update tools/MT-Unsafe.py to find all the unsafe functions listed in man elf_flagelf

[andrew-aitchison]

Update tools/MT-Unsafe.py to find all the unsafe functions listed in man elf_flagelf

• this man page lists several unsafe functions on one source line.

Update addons/threadsafety.py to include these functions.

[danmar]

I would like that the PR title is not chopped like this.

it wouldn't hurt with a line in releasenotes to mention this improvement.

testing: I am not sure what we can test but feel free to create a regression test if you can. Provide a made up input to MT-Unsafe.py and check that it outputs certain symbols?

[andrew-aitchison]

Title fixed.
The other two suggestions are also good.

[andrew-aitchison]

testing: I am not sure what we can test but feel free to create a regression test if you can. Provide a made up input to MT-Unsafe.py and check that it outputs certain symbols?

I have an input for MT-Unsafe.py and an expected output.
testrunner is probably not a good place to run a python script; where should I add this to the regression tests ?

[danmar]

testrunner is probably not a good place to run a python script; where should I add this to the regression tests ?

that is correct.

I suggest some pytest testing in addons/test folder. there is no threadsafety_test.py there now which I spontanously feel is weird. but there is a threadsafety folder there I don't know how that is used.

https://github.com/cppcheck-opensource/cppcheck/tree/main/addons/test

[andrew-aitchison]

I suggest some pytest testing in addons/test folder. there is no threadsafety_test.py there now which I spontanously feel is weird. but there is a threadsafety folder there I don't know how that is used.

Hmm. Looks like I did that. I'll have to figure out what I was thinking ...