Restore warning for #14392 - #8859
Open
chrchr-github wants to merge 2 commits into
Open
chrchr-github wants to merge 2 commits into
chrchr-github wants to merge 2 commits into
Conversation
danmar
reviewed
Sep 17, 2026
| " return false;\n" | ||
| "}\n"); | ||
| TODO_ASSERT_EQUALS("[test.cpp:6:12] -> [test.cpp:7:21]: (style) Assigned value 's.g()' is always true [knownConditionTrueFalse]\n", "", errout_str()); | ||
| ASSERT_EQUALS("[test.cpp:6:12] -> [test.cpp:8:16]: (style) Return value 'b' is always true [knownConditionTrueFalse]\n", errout_str()); |
Collaborator
There was a problem hiding this comment.
I am not sure. what is the motivation to warn here?
this checker is about known conditions from the start. I documented my understanding of this in man/checkers/knownConditionTrueFalse.md. If that motivation/description can be improved feel free to do it.
I feel that such return value warning should be a separate checker as you said here:
#8853 (comment)
Collaborator
Author
There was a problem hiding this comment.
The motivation still comes from https://trac.cppcheck.net/ticket/14392
We warn for return s.g();, so we should also warn if the result is stored in an intermediate variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.