Fix ValueError on unlisted CrateDB column type identifiers - #830
Merged
Merged
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
mfussenegger
approved these changes
Sep 14, 2026
bgunebakan
deleted the
bilal/829-datatype-enum-reads-raise-valueerror
branch
September 14, 2026 15:54
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
DataType._resolve()that returnsNonefor identifiers unknown to this client instead of raising error.It is out of the scope of the issue ticket but I added a converter for
DataType.UUIDin this PR as well, because the enum member is introduced here.Before the round trip was asymmetric.uuid.UUIDis already accepted as a parameter on the write side, but reads came back asstr.DefaultTypeConverternow decodes UUID columns touuid.UUID.Checklist