fix macos -frameworks missing from configure libs - #1241
Merged
Merged
Conversation
crazywhalecc
approved these changes
Sep 24, 2026
fukumen
added a commit
to fukumen/static-php-cli
that referenced
this pull request
Sep 27, 2026
* Remove patches/0001-darwin-configure-libs.patch * Upstream crazywhalecc#1241 (605ba67) fixed the same configure LIBS line by appending resolved macOS frameworks instead of the full EXTRA_LIBS set The patched hunk no longer applies after upstream v3, so the workflow "Apply local patches" step would fail. The upstream approach keeps the crazywhalecc#1236 old-glibc polyfill fix on Linux and passes macOS frameworks only where configure probes need them.
fukumen
added a commit
to fukumen/static-php-cli
that referenced
this pull request
Sep 27, 2026
* Fix macos -frameworks missing from configure libs (upstream crazywhalecc#1241) * Add PhpUnixConfigureTest for configure LIBS behavior Supersedes patches/0001-darwin-configure-libs.patch, reverted in the parent commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
hopefully fixes https://github.com/php/frankenphp/actions/runs/32659796963/job/97244892520?pr=2618