Repository navigation
Conversation
AI assisted. ingestorNumber was 7 for 9 fetches. The channel is drained while the fetches run, so it needs no buffer, and no count to keep in sync.
kpetremann
reviewed
Oct 8, 2026
| "github.com/criteo/data-aggregation-api/internal/report" | ||
| ) | ||
|
|
||
| const ingestorNumber = 7 |
Member
There was a problem hiding this comment.
Even if this number should be updated (it will in the interfaces PR), I don't see how it is causing an issue.
The number is arbitrary set to the number of fetch, but it could be lower or higher, it does not really matter. The idea was only to avoid having a blocking channel;
Before your change: non blocking with 7 slots
After your change: blocking with 1 slot
The channel is non-blocking for freeing go routines as soon as possible. This was more as a best practice rather than critical.
Contributor
Author
There was a problem hiding this comment.
agreed, it is not an issue if the count is not up to date and avoids blocking at least up to this count, I will close this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assisted.
The buffer size was 7 for 9 fetches. The channel is drained while the fetches run, so it needs no buffer, and no count to keep in sync. A full DA1 build against a local Netbox succeeds.