Repository navigation
Conversation
A single device failing its OpenConfig conversion made the compute step return an error, which discarded the build for every device and left the API serving nothing. Build.AllDevicesMustBuild was only honoured for precompute failures. Devices failing to convert are now set to nil, like the ones failing to precompute, so the API serves an empty configuration for them while the other devices are published. The build only fails on a conversion error when Build.AllDevicesMustBuild is enabled. Conversion errors are also reported as compute messages instead of precompute ones.
Member
|
This was on purpose. A failure at Compute step is a bug. It must never happen, as it means the input is wrong, which must not happen (the CMDB models must protect against that). |
kpetremann
requested changes
Oct 13, 2026
kpetremann
left a comment
kpetremann
left a comment
Member
There was a problem hiding this comment.
Compute failure is a code (or CMDB bug). It must be considered as a complete failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single device failing its OpenConfig conversion made the compute step return an error, which discarded the build for every device and left the API serving nothing. Build.AllDevicesMustBuild was only honoured for precompute failures.
Devices failing to convert are now set to nil, like the ones failing to precompute, so the API serves an empty configuration for them while the other devices are published. The build only fails on a conversion error when Build.AllDevicesMustBuild is enabled.
Conversion errors are also reported as compute messages instead of precompute ones.