Repository navigation
fix(logging): drop the env-filter feature - #41
Merged
Merged
Conversation
#38 enabled tracing-subscriber's env-filter feature, and Cargo unifies features across a build, so it was on in every function that depends on the SDK. That changes tracing_subscriber::fmt::init(): with RUST_LOG unset it installs an EnvFilter that defaults to ERROR instead of INFO, so a function that sets up logging itself lost its info and warn logs. Filter with Targets instead, which needs no extra feature. RUST_LOG still replaces the level selection for target=level directives and bare levels; a RUST_LOG with span or field filters is ignored with a warning, and the --debug selection applies. Signed-off-by: Jonasz Małecki <jonasz@upbound.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38 enabled tracing-subscriber's
env-filterfeature, which Cargo turns on in every function that depends on the SDK, so a function that callstracing_subscriber::fmt::init()itself logs only errors whenRUST_LOGis unset. This filters withTargetsinstead, which needs no extra feature:RUST_LOGkeeps working fortarget=leveldirectives, and a value with span or field filters is ignored with a warning.