Conversation
buildNetwork completed the octave with mode.append(iComplement), so the
list passed in came back longer:
mode = ['M3', 'M3']
scale.OctaveRepeatingScale('c4', mode)
mode # ['M3', 'M3', <music21.interval.Interval d4>]
Reusing that list for a second scale then built a different scale.
Build a new list instead.
|
coverage: 93.35%. remained the same — float3:octave-repeating-scale-keeps-callers-list into cuthbertLab:master |
Contributor
Author
|
I saw that agents.md mentions changing the copyright years, which I didn't do for previous PRs |
Member
no worries -- it's not a big deal. :-) |
Member
|
this is fine -- we might tighten the typing of mode to something like list[interval.Interval] and rename it from mode. But a lot of these Abstract scales probably need to be rethought anyhow... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildNetwork completed the octave with mode.append(iComplement),
Reusing that list for a second scale then built a different scale.