Grant profile_contributors the issues:read scope gh-profiler needs - #2040
Merged
Merged
Conversation
The workflow's permissions block granted only pull-requests: write, and a
permissions block caps the Actions token rather than adding to it. An Actions
token is a GitHub App installation token, so with no issues scope it cannot
resolve Issue objects: gh-profiler's issue-activity search came back as a list
of empty nodes and it died on KeyError: 'repository'. PR parsing succeeded one
function earlier because PullRequests: write was granted.
The step had never actually run before -- every earlier trigger skipped it
because the author already had a merged PR -- so this broke on first use, in
run 35530668612.
Also stop a gh-profiler crash from failing the job. Note that GitHub returns the
unreadable nodes as {} with exit 0 and no errors array, so simply skipping bad
nodes would report a spam account as having zero external issues and give it two
green flags. Reporting that profiling could not run keeps the author visible
instead of passing them as clean; the comment on the PR says so, and the
traceback stays in the log.
|
coverage: 93.349%. remained the same — fix-profiler-issues-permission into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow's permissions block granted only pull-requests: write, and a permissions block caps the Actions token rather than adding to it. An Actions token is a GitHub App installation token, so with no issues scope it cannot resolve Issue objects: gh-profiler's issue-activity search came back as a list of empty nodes and it died on KeyError: 'repository'. PR parsing succeeded one function earlier because PullRequests: write was granted.
Also stop a gh-profiler crash from failing the job.
AI-Assisted (Claude)