Skip to content

(AI Generated) Keep MusicXML arpeggios with the same number apart - #2041

Open
rdebroiz wants to merge 1 commit into
cuthbertLab:masterfrom
rdebroiz:fix/arpeggio-spanner-per-offset
Open

rdebroiz wants to merge 1 commit into
cuthbertLab:masterfrom
rdebroiz:fix/arpeggio-spanner-per-offset

Conversation

@rdebroiz

@rdebroiz rdebroiz commented Sep 22, 2026 •

Copy link
Copy Markdown

Fixes #2039: MusicXML import merges every <arpeggiate> sharing a number into one spanner, so MuseScore files (always number="1") end up with a single arpeggio per part.

The importer now matches an ArpeggioMarkSpanner on number and offset. Other spanners close on type="stop", so only arpeggios were affected. Version bumped to 11.0.0b10 since cached parses are wrong.

AI-assisted (Claude)

@rdebroiz
rdebroiz force-pushed the fix/arpeggio-spanner-per-offset branch from 631382e to 5f9405e Compare September 22, 2026 08:23
@coveralls

coveralls commented Sep 22, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 93.349%. remained the same — rdebroiz:fix/arpeggio-spanner-per-offset into cuthbertLab:master

number only tells apart simultaneous arpeggios, so match ArpeggioMarkSpanners
on number and offset instead of reusing the incomplete one. Version bumped to
11.0.0b10 to invalidate cached parses. Fixes cuthbertLab#2039.
@rdebroiz
rdebroiz force-pushed the fix/arpeggio-spanner-per-offset branch 4 times, most recently from 93055a3 to 896d367 Compare September 22, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MusicXML import merges every <arpeggiate number="1"> of a part into one ArpeggioMarkSpanner

2 participants