Conversation
Look the voice up with voices.getElementById for string and int ids alike, so a string id absent from the next measure no longer raises KeyError. Fixes cuthbertLab#2024.
rdebroiz
changed the title
|
coverage: 93.35% (+0.001%) from 93.349% — rdebroiz:fix/make-ties-missing-voice-id into cuthbertLab:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2024:
makeTiesraisesKeyErrorwhen a rest crossing a barline belongs to a string-id voice missing from the next measure, which breaks MusicXML export.The voice is now looked up with
mNext.voices.getElementById(vId)for string and int ids alike, as suggested in the issue.Nonefalls back to the measure, and unlike anorchain this doesn't skip a matching empty voice.No test added on purpose. The one in the closed #2031 did not test
makeTiesdirectly: it went throughmakeRests, which callsmakeTies.AI-assisted (Claude)