Pass the altered degrees to find in derive (AI) - #2044
Merged
mscuthbert merged 1 commit intoSep 24, 2026
Merged
Conversation
|
coverage: 93.35%. remained the same — float3:derive-with-altered-degrees into cuthbertLab:master |
Member
|
Looks good. When you can fix the conflicts from other PR I will merge. |
derive called IntervalNetwork.find without the scale's alteredDegrees,
which deriveRanked and deriveAll both pass, so a harmonic minor scale
was derived as if it were a natural minor:
>>> scale.HarmonicMinorScale().derive(['C', 'D', 'E-', 'B'])
<music21.scale.HarmonicMinorScale A harmonic minor>
A harmonic minor has neither the E- nor the B; C harmonic minor has
all four, and is what deriveRanked ranks first.
float3
force-pushed
the
derive-with-altered-degrees
branch
from
September 24, 2026 06:01
389bccf to
e299316
Compare
Contributor
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
derive called IntervalNetwork.find without the scale's alteredDegrees, which deriveRanked and deriveAll both pass, so a harmonic minor scale was derived as if it were a natural minor: