ci: add scheduled workflow to alert translators of English rule changes - #758
Conversation
|
as I understand it after some research, the cron means "14:03 UTC on the 1st and 15th of every month" |
|
I'm generally much more comfortable with Python compared to JS. All things being equal, I'd prefer Python otherwise as a) at least Neil and I already know it well and b) it's also what's used for infra-related code in MathCAT anyway. If the GitHub API integration is worth it though, we can definitely keep it. |
|
@moritz-gross: This isn't JS, at most it is a shell script which I believe is standard for this. To me the question is whether this is helpful or will noise because translators might only be able to work on this once/month of less and when they do work, they would run the audit tool (hopefully). I lean towards this being useful, but I'd like to get feedback. @MartheGjelstad, thoughts? |
it's both. in the |
|
@moritz-gross: you're right, I thought it would need an external JS file and didn't look at the bottom to see it is embedded in the action. I asked AI if it could write something in shorter as a shell script or python. It did come up with something shorter for part of it using a shell script; it said python is not well suited to the task. Overall, it said JS/GraphQL is the best approach. Still, the question remains: is this noise for the translators or useful? |
in the last big meeting, the answer was a clear yes, as I understood it |
|
Yes, in the meeting we had about the release process (August 17), we agreed on this procedure where the translators are being alerted on the first and 15th every month. I think we should try this workflow. We can adjust it later if we want to recieve less frequent notifications about changes. |
|
@Johannes-spsm what do you think about my suggestions in the review? They all sound pretty quick to do, so we can get this merged soon. I don't want to poke in someone else's PR (at least not without getting their POV first) |
|
@moritz-gross I agree the comment explaining the cron schedule is a good addition. I believe the GitHub API integration is worth using JS for. This PR is ready to be merged imo. |
Closes #496