Refactor: Replace custom path utilities with Path API and update zip methods accordingly - #775
Merged
NSoiffer merged 1 commit intoSep 24, 2026
Conversation
…p methods accordingly
Collaborator
|
@moritz-gross Except for some special cases, "/" works everywhere in Rust. There is Please test this with |
Collaborator
Author
|
(I'm getting this warning though, which is fine I guess: warning: methods rule_files_cache_is_empty, definitions_files_cache_is_empty, and definitions_files_cache_path are never used ) I've not used the flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Side note: This file also contains some unused imports. should I remove them as well?
and I'm surprised somewhat that the previous implementation is not buggy in some way?? hard-coding a path separator like "/" is usually a bad idea from my experience, given the kinds of this operating systems are doing.