Refactor navigation state management: unify position and command stacks into a single history vector - #776
Merged
NSoiffer merged 3 commits intoSep 24, 2026
Conversation
…ks into a single history vector
Collaborator
Author
|
the failing test doesn't reproduce locally, so something about the CI setup is off.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a hard time understanding what's happening in some files, so I'll keep suggesting some ways in how I think it can be done a bit smoother. Either my proposals are good enough to be merged, or I'll find out how I am misunderstanding the code ;)
regarding your comment in the code: I'm 99% sure Vec is the correct datastructure for this. Ideally, you want to use a contiguous memory layout, as opposed to pointer chasing in a linked list.
See for example also VecDeqeue for some other use cases where we might want to manipulate both ends. But for this, Vec seems perfect. Its usage as a stack is also documented in https://doc.rust-lang.org/std/vec/struct.Vec.html