use elements.rs as chemistry database - #782
Merged
moritz-gross merged 1 commit intoSep 24, 2026
Merged
Conversation
elements.rs as chemistry database
Collaborator
Author
|
TODO: check difference in MathCAT size, and how to judge such a thing |
Collaborator
Author
|
binary size seems to actually shrink ?!?. Running this: gives the result The "eliminating-dead-code" step you mentioned is Link-Time Optimization as I just learned?! Seems to work well then. @NSoiffer have you ever used the size command for inspecting section sizes of binaries? That could be interesting to inspect it further, but I think this would be more of a fun side-project than actually pragmatic here. So in summary, this PR seems good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while wandering some more through the codebase, I saw that we have a whole periodic table laying around here.
I think this is something we'd better hand off.
I found the neat crate elements_rs for this. In particular, having categories like
ElementCategory::NobleGas(not to speak ofAlkalineEarthMetaletc.)next to refactoring code, I this also uncovered a buggy test re Ammonia: The electronegativity of Nitrogen is 3.04, and that of Hydrogen is 2.20, so NH_3 is in descending order.
most likely, there is way more to hand off in this file, but this looks like an easy-to-do thing for now.