ru: addition of speech rules improvements and fixing conflicts with main branch - #822
Open
Kostenkov-2021 wants to merge 188 commits into
Open
Kostenkov-2021 wants to merge 188 commits into
Kostenkov-2021 wants to merge 188 commits into
Conversation
24 test passes, 3 test failures
… atomic numbers in prescripts to bump up their liklihood number. This allows single character elements with pre subscripts that match their atomic number to be considered chemistry.
Add French to the braille testing file. New French braille tests.
Updated French test files and added the chemistry file to the tests
Incorporate the braille.rs trait-based refactor from main. The French braille code is now wired through the BrailleCode trait/registry: - register "French" in get_braille_code() - French struct impls cleanup (french_cleanup), get_braille_chars (get_braille_ueb_chars), and needs_grouping (needs_grouping_for_french) - keep French-specific helpers (FRENCH_INDICATOR_REPLACEMENTS, french_cleanup, needs_grouping_for_french) French now uses SPEECH_DEFINITIONS (like the other codes) instead of BRAILLE_DEFINITIONS: braille.rs is taken from main wholesale and only the French-specific items are re-added, with needs_grouping_for_french converted to SPEECH_DEFINITIONS. No new test failures: tests/braille results are identical to the pre-merge French baseline (1394 passed, 57 failed). Co-authored-by: Cursor <cursoragent@cursor.com>
Now at 78 pass/15 fail.
…f the failures being open questions.
Co-authored-by: Cursor <cursoragent@cursor.com>
…was overly broad, so I removed scripted letters and numbers. That rule made its way into other braille codes, so I removed them everywhere. All tests pass.
…(for accented letters) so that the pattern for them looks like: ``` - "Ñ": [t: "CA⠘⠻L⠝"] # 0x00D1 ``` Added a few tests.
…or!() message. May want to change the promoted name...
…bers don't conflict with letters. Add code to handle `;` special case if there are "blocks" in the expr
Now at 185 passed; 4 failed
Added several more chem arrows.
…ween different arrows that go in the same direction. That seems wrong, but the spec is silent on the alternatives
…or a more restricted version for nested munder/mover. They add a "," between lines. This was done for limit_x_tends_1_14_2_01_corrected and limit_x_tends_1_14_2_02_corrected
Clarify Russian wording for membership of standard number sets (ℕ, ℤ, ℚ, ℝ). Add a dedicated set-member-number-set rule and update ClearSpeak/SimpleSpeak shared rules to speak e.g. "принадлежащих множеству целых чисел" instead of ambiguous/calque forms. Fix related translations in unicode-full (remove English OT markers, replace «член» → «элемент»), simplify interval terminology in general rules, add FunctionApplicationWord connector, and refine several UI phrases (table/diacritical labels). Update and add unit tests in tests/Languages/ru to assert the new phrasing.
This update improves Russian mathematical speech and navigation by fixing set-membership wording, compact Unicode operator and relation names, and table navigation boundary phrasing. It also adds targeted regression tests covering the corrected column navigation message and compact Unicode output.
Update Russian Unicode names in `Rules/Languages/ru/unicode-full.yaml` to use the orthographically correct `ё` variants for overline and underline descriptions. This keeps the terminology consistent across related symbols and aligns the translations with the language's spelling conventions.
Collaborator
|
a job fails. Have you looked into this? does this look caused by changes in this PR or somewhere else? |
Contributor
Author
|
Hi @moritz-gross The only failing job was At that line, The corresponding So I don't see evidence that the failure is caused by this PR. A rerun should confirm the intermittent nature of the issue. |
…aisy#820) * replace buggy Display implementation for Pronounce with Debug trait * remove unused `eloquence` field and related code from `Pronounce` struct * fix outdated syntax
Add Russian rules to recognize norms (double bars and magnitude) and nested double overline; treat paired absolute-value as "норма" and ordinary as "модуль". Fix multiline handling to skip duplicated '=' and final '.' in gathered/continued lines and announce visual lines. Add translations for named operators (max/min/sup/lim) including munder lower-limit phrasing and context-sensitive wording for overline and infinity in unicode. Adjust munder/mover default wording. Update and add unit tests (mtable, shared, linear_algebra) to cover these cases.
…his looks much better. All language `definitions.yaml` are updated. Fix parsing of `IntentMappings`. Parsing now lives in one place, so ratio-style "name : glue" pairs, arity templates, and bracketing speech stay consistent across languages. This all started as a fix to daisy#709, but then I discovered that the format used in `IntentMappings` was parsed incorrectly in some cases (such as "ratio").
* v1 of rule coverage report * Add Python script to generate Markdown and HTML rule coverage reports * clarify name of logfiles * Switch rule coverage events to JSONL format * switch to jinja2 templates * Exclude Unicode mapping files from rule coverage report and improve report generation * Exclude definition files from rule coverage report and update related documentation * Add hit counts and test details to rule coverage report Enhance the rule coverage report to include hit counts, test details, and hoverable tooltips for matched rules. Improve report formatting and coverage fraction calculation. Update related tests and documentation to reflect these changes. * fix title * Simplify rule coverage event recording * Stream rule coverage events and trim unused report fields * Suppress unused variable warning when `rule-coverage` feature is disabled * Migrate `rule_coverage` implementation to a dedicated `rulecoverage` package, separating logic, templates, and CLI. * uv run ruff format * simplify dataclasses in Python * remove "loaded" as statistic for rule coverage * remove MD report and only keep HTML. simplify rest accordingly. * uv ruff format
Adds Russian-specific speech handling for arrays, gathered derivations, function aliases, typographic quotes, and linear algebra constructs such as vector products, projections, and norms. It also introduces a RussianFunctionAliases definition table so common names like det, arctan, and Cauchy are spoken correctly in ClearSpeak and SimpleSpeak.
Linux library size: 0.58 MiB (+0.32%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
Kostenkov-2021
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify Russian wording for membership of standard number sets (ℕ, ℤ, ℚ, ℝ). Add a dedicated set-member-number-set rule and update ClearSpeak/SimpleSpeak shared rules to speak e.g. "принадлежащих множеству целых чисел" instead of ambiguous/calque forms. Fix related translations in unicode-full (remove English OT markers, replace «член» → «элемент»), simplify interval terminology in general rules, add FunctionApplicationWord connector, and refine several UI phrases (table/diacritical labels). Update and add unit tests in tests/Languages/ru to assert the new phrasing.
Also conflicts with the Main branch has been resolved.
Resolves #798
Dependency
This PR depends on #840 for the intent inference required by the new norm,
limit, and gathered-expression speech rules. Merge #840 first, then update
this branch before rerunning CI.