Conversation
This was referenced Aug 26, 2026
danielkov
marked this pull request as ready for review
August 26, 2026 12:47
This was referenced Aug 26, 2026
danielkov
force-pushed
the
feat/acp-v2-session-inject
branch
from
August 30, 2026 11:21
1204e2b to
64244da
Compare
danielkov
force-pushed
the
feat/acp-v2-session-inject
branch
from
September 2, 2026 12:23
0199d04 to
8661c20
Compare
danielkov
added a commit
that referenced
this pull request
Oct 1, 2026
Lands the ACP v2 session injection stack (previously #13, kept unmerged behind a git patch) and David's inline media budget (#25), now depending on published fork crates instead of git revisions. - `agentkit-acp` depends on [`agentkit-acp-sdk`](https://crates.io/crates/agentkit-acp-sdk) 2.2.0: the upstream `agent-client-protocol` SDK (current main) plus session injection, tracked response receipts and bounded transports. It uses [`agentkit-acp-schema`](https://crates.io/crates/agentkit-acp-schema) 1.9.1 for the schema. Library names are unchanged, so code still imports `agent_client_protocol`. - Injection stays behind the `unstable-inject` feature; default features are unchanged apart from the SDK moving from 2.0 to 2.2. - Upstream ACP v2 now requires `session/prompt` responses to carry the accepted user message id. The id is allocated when the prompt is accepted and echoed by the later `user_message` update. - Loop: preserve and bound interrupted streamed responses, and retire interrupted turns without resuming execution. - Bumps `agentkit-acp` to 0.10.12 and `agentkit-loop` to 0.10.13. --------- Co-authored-by: David Danialy <david.danialy@speakeasy.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds ACP v2 session injection to AgentKit behind the
unstable-injectfeature.steerinjections while a turn is runninguser_messageupdateThe same injection coordinator is used by
AcpHeadlessRuntimeand by hosts with custom persistent session actors. The public host API covers session binding, update delivery, prompt conversion, turn lifecycle, cancellation, revoke, and safe-boundary delivery without exposing the internal locks or queues.Dependencies
ACP v2 foundation is already merged into
mainvia #12. This branch is rebased onmainafter the AgentKit 0.10.12 provider release.External protocol dependencies:
The branch pins schema
6e7e044f9464c4fd652d90699a09e9edc8b3bbadand Rust SDK2f039993d1d6ed8da35b38c31f54a7cbb7338c70.Consumer