Repository navigation
[Backport release-1.19] fix: Deflake DaprJobsIT and let CI integration retries finish - #1830
Merged
Merged
Conversation
* fix: Deflake DaprJobsIT and let CI integration retries finish DaprJobsIT compared the expected due time, always formatted with milliseconds, against Instant.toString(), which drops them when they are zero. The tests now compare Instants truncated to milliseconds. The build job timeout equalled one integration attempt, so the retry was cancelled before it could finish. Raise the job timeouts to fit both attempts. Signed-off-by: Javier Aliaga <javier@diagrid.io> * fix: Fit both retry attempts in the Durable Task job timeout The Durable Task job allowed 7 minutes while its retry step allows two 5-minute attempts, so a second attempt had about a minute and a half. Raise the job timeout to 15 minutes and note on each retried job that the job timeout covers every attempt. Signed-off-by: Javier Aliaga <javier@diagrid.io> --------- Signed-off-by: Javier Aliaga <javier@diagrid.io> (cherry picked from commit 77f6794)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.19 #1830 +/- ##
==================================================
- Coverage 79.15% 79.11% -0.04%
Complexity 2604 2604
==================================================
Files 264 264
Lines 7785 7785
Branches 820 820
==================================================
- Hits 6162 6159 -3
- Misses 1263 1266 +3
Partials 360 360 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
javier-aliaga
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 77f6794 from #1827.