ci: enforce lint and formatting instead of silently fixing them - #123
Merged
Merged
Conversation
pnpm lint ran oxfmt in write mode and oxlint --fix, so CI rewrote an unformatted tree and passed: format and lint drift was never caught. Make lint non-mutating (oxfmt --check, plain oxlint) and add a fix script that runs everything lint does plus the auto-format and auto-fix passes. Document both in CONTRIBUTING. 🤖 Generated with [OpenCode](https://opencode.ai) (Smart-router)
daquinoaldo
force-pushed
the
ci/lint-enforcement
branch
from
September 16, 2026 10:43
d55a2bb to
182ff76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm lintranoxfmtin write mode andoxlint --fix, so CI silently rewrote an unformatted tree and passed — format and lint drift was never caught.lintis now non-mutating:oxfmt --check && oxlint && knip && tsc --noEmitfixscript that runs everythinglintdoes, plus the auto-format (oxfmt) and auto-fix (oxlint --fix) passes:oxfmt && oxlint --fix && knip && tsc --noEmitVerified:
pnpm lintandpnpm fixboth pass on a clean tree.🤖 Generated with OpenCode (Smart-router)