feat!: remove standalone binaries and the pkg update check - #124
Merged
Merged
Conversation
The standalone binaries shipped an archived bundler (vercel/pkg) with an EOL Node 16 runtime, and the update check they carried never worked. Node 24+ (required by the package) makes them unnecessary: install the npm package instead. Remove the pkg config, the release-asset upload, the binaries section from the README, and the dead update-check code. 🤖 Generated with [OpenCode](https://opencode.ai) (Smart-router)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the standalone-binary feature entirely.
The binaries bundled the app with vercel/pkg (archived upstream) on an EOL Node 16 runtime, and the update check they carried (
checkUpdates) never worked even inside the binary. The package already requires Node ≥ 24, so anyone without Node cannot use it anyway.pkgconfig from package.jsoncheckUpdatescode from src/certs.tsBreaking: the GitHub release assets (
https-localhost-linux/macos/win.exe) will no longer be produced. Users without Node must install Node (≥ 24) andnpm i -g https-localhost.Verified:
pnpm lintgreen,pnpm testgreen (except the 2 pre-existing environmental port-8080 failures on my machine).🤖 Generated with OpenCode (Smart-router)