Conversation
…pe layout identity
…idebar autoscroll
… privacy lifecycle CI
… and the login wrapper
arzafran
marked this pull request as ready for review
September 12, 2026 13:48
There was a problem hiding this comment.
The diff applies targeted fixes for audit findings: CI gains notification UI regression and scrollback privacy tests; MCP socket bridge now respects per-method timeouts and retries on EAGAIN; CLI argument parsing protects flag values from being stripped as trailing flags, and dialog accept preserves verbatim text; hook confirmation logic is corrected. No secrets, injection, data-loss paths, or type-safety escapes were observed in the visible hunks.
Review coverage: 500/11735 diff lines supplied. Partial input (truncated: diff, standards). Inline comments are limited to fully visible, valid right-side hunks. Reviewed commit: fbe35a0a730255c0e7565c5b277a8c5c94ce5db8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes all 42 findings from the 2026-09-11 codebase audit (8 high, 31 medium, 3 low) so a fresh build can be cut. The highest-impact effects for users and agents:
Review order
Test plan
XCUIApplication.statereporting foreground on the virtual display while the app never became active; the test now judges focus by the workspace's frontmost application.programa browser dialog accept ""and confirm the page receives an empty string.Notes
-key valuepairs so restore still runs (5171c0a).