Repository navigation
chore: remove dead Swift code, unused strings and stale comments - #411
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Removes about 1,300 lines of Swift code that nothing calls, 18 UI strings nothing shows, and comments that describe old history instead of the current code. The app behaves the same. The four tmux-compat commands that only ever printed "not supported yet" (
popup,bind-key,unbind-key,copy-mode) now report an unknown command instead.Summary
Review order:
Sources/TerminalController.swift,Sources/TerminalController+Debug.swift,CLI/programa.swift,CLI/SocketClient.swift: zero-caller helpers and constants. The at-budget files gain headroom.contracts/v2/methods.jsonand the generated files:debug.viewtreeremoved (no caller in CLI, MCP, tests or scripts). Regenerated withgen-v2-contract.py.Sources/WorkspaceContentView.swift,Sources/Panels/TerminalPanel.swift: thetmuxActivePaneoverlay target, which never had a producer for its layout report. Documented indocs/removed/tmux-active-pane-overlay.md. The overlay settings gate and thebonsplitPanetarget stay, since live code and tests use them.TabManager,Workspace, model and UI members with no callers; 20 unused shortcut wrappers inKeyboardShortcutSettings.swift;promptRenameSelectedWorkspace; the emptySources/GhosttyTerminalView.swiftand its project entries.Localizable.xcstringsdeletions (each key had 0 references) and present-tense rewording of history comments.Contract change:
tests_v2/test_tmux_compat_matrix.pynow asserts the four removed tmux commands are rejected, instead of asserting the old "not supported" message.Kept on purpose:
recordSurfaceDrawand the draw-count stats (a UI test readsrenderDrawCount), andprogramaWithWindowFirstResponderBypass(per-event path, needs its own review).Test plan
check-structural-budgets.py,check-v2-contract.sh,check-settings-docs.pypass locally.programa,programa-cliandprograma-unitbuild-for-testing succeed locally.