Repository navigation
chore: remove cmux upgrade shims - #412
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Programa stops reading settings, config files and environment variables left over from when it was called cmux. Anyone who upgraded from cmux was migrated long ago, so current users see no change. Someone jumping straight from an old cmux install would start with default settings.
Summary
Removed:
cmux*toprograma*UserDefaults migration (Sources/ProgramaApp.swift).~/.config/cmux/settings.json,~/.config/cmux/cmux.jsonand projectcmux.jsonlookups, including the trust-store migration branch.cmuxOnlysocket mode alias (parser, known modes, schema enum).CMUXTERM_*andCMUX_*env fallbacks in the CLI and Bonsplit debug log, thecom.cmuxterm.app.debugexclusion,cmux-socket name prefixes, the old wrapper header match, the palette history key rewrite.cmuxbinary (bash, zsh, fish).docs/removed/cmux-upgrade-shims.md.Kept on purpose:
cmuxPortBase/cmuxPortRange: they are the live keys current users store port settings under, not shims."protocol": "cmux-socket"in the capabilities reply (wire value).scripts/sparkle_generate_keys.sh(the signing key lives under it).Test plan
check-structural-budgets.py,check-v2-contract.sh,check-settings-docs.pypass locally.programabuild andprograma-unitbuild-for-testing succeed locally;bash -n,zsh -n,fish -nclean on the integration files.