Repository navigation
fix: Window menu tiling items are disabled - #413
Open
exequiellares wants to merge 1 commit into
Open
exequiellares wants to merge 1 commit into
exequiellares wants to merge 1 commit into
Conversation
AppKit validates Fill, Center, Move & Resize, Full Screen Tile and Move to Display against NSWindow.isMovable. The main window set it to false to stop clicks under the transparent titlebar from becoming native drags; that is now handled by MainWindowHostingView returning false from mouseDownCanMoveWindow, the same approach upstream Ghostty uses.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The Window menu's Fill, Center, Move & Resize, Full Screen Tile and Move to Display items (and their shortcuts) are greyed out in Programa. This makes them work again.
Summary
macOS enables those items only when the window reports
isMovable == true. The main window was created withisMovable = false(from the cmux-era titlebar drag fix, and re-asserted in the chrome configure pass), which disables the whole tiling family. The flag was off to stop clicks under the transparent titlebar from turning into native window drags; that is now handled byMainWindowHostingViewreturningfalsefrommouseDownCanMoveWindow, the same approach upstream Ghostty uses with itsNonDraggableHostingView.isMovableByWindowBackgroundstays off, and the explicitperformDragpaths are unchanged.Test plan