Repository navigation
test: run the sidebar markdown and close-workspaces dialog tests - #414
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Two test files were in the repo but never ran, because they were missing from the Xcode project. This adds them so CI runs them. One of them talked to the app through the old socket protocol that no longer exists, so it is updated to the current one.
Summary
project.pbxproj: addsprogramaTests/SidebarMarkdownRendererTests.swiftto the unit test target andprogramaUITests/CloseWorkspacesConfirmDialogUITests.swiftto the UI test target (4 entries each).CloseWorkspacesConfirmDialogUITests.swift(contract change): the removed v1 line commands (ping,new_workspace,list_workspaces,select_workspace) become v2 JSON-RPC calls (system.ping,workspace.create,workspace.list,workspace.select). Adds the socket-controlled launch setup copied fromSidebarHelpMenuUITests. No assertion changed: both tests still check the alert appears and Cancel keeps the workspace counts.SidebarMarkdownRendererTests.swift: unchanged.Follow-up, not in this PR:
SidebarHelpMenuUITests.swift:760-762still sends a v1ping.Test plan
programa-unitandprograma-cibuild-for-testing succeed locally; both new files compile.MarkdownFindRegressionTests.test-e2e.ymlwithtest_filter=CloseWorkspacesConfirmDialogUITestspasses on this branch.