Normalize jobs PyDABs acceptance surface and drop coverage exception - #6548
Merged
Sankalp-Mittal merged 1 commit intoSep 8, 2026
Conversation
Sankalp-Mittal
marked this pull request as draft
September 7, 2026 13:10
Sankalp-Mittal
marked this pull request as ready for review
September 7, 2026 13:16
Collaborator
Integration test reportCommit: 2bd8223
Top 24 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Sep 8, 2026
Sankalp-Mittal
force-pushed
the
sankalp-mittal/pydabs-jobs-tests-normalize
branch
from
September 8, 2026 14:23
db909a0 to
37ecd9c
Compare
Add the standard jobs-support/ fixture so jobs matches every other PyDABs resource, then remove the _LACKING exception list from test_python_support_coverage. The guard now uniformly requires a <plural>-support/ fixture for every resource. Co-authored-by: Isaac <no-reply@databricks.com>
Sankalp-Mittal
force-pushed
the
sankalp-mittal/pydabs-jobs-tests-normalize
branch
from
September 8, 2026 15:14
37ecd9c to
2bd8223
Compare
Sankalp-Mittal
deleted the
sankalp-mittal/pydabs-jobs-tests-normalize
branch
September 8, 2026 16:18
chenyuem-db
pushed a commit
to chenyuem-db/cli
that referenced
this pull request
Sep 9, 2026
…atabricks#6553) Stacked on databricks#6548. ## Changes Enables PyDABs codegen to model the SDK `time.Time` type, which unblocks generating `resources.Secret` (its `expire_time` field is a `*time.Time`) and drops it from the codegen denylist. `time.Time` is mapped to Python `str` — an RFC3339 timestamp string. This mirrors how the Go side already models the type at its own config boundary (`libs/dyn/convert/sdk_native_types.go` treats `time.Time` as a string), so a PyDABs value flows unchanged through the same Go normalization pipeline that `databricks.yml` uses. Regenerated output adds the `secrets` module and its wiring; the `databricks.bundles.core` public-API snapshot update is purely additive (`add_secret`, `secret_mutator`, `secrets`). ## Tests - New `acceptance/bundle/python/secrets-support/` fixture (required by `test_python_support_coverage`): loads a Secret from YAML and Python, runs a `secret_mutator` over both, and exercises `expire_time` (RFC3339 string) end to end. `value` is a default-less variable reference supplied at validate time, as the secret value validator requires; direct-engine only. Passes with and without `-update`. - `pydabs-test` 423 passed; codegen unit tests 37 passed. ## Notes - A changelog fragment (`.nextchanges/bundles/`) is still to be added. This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
pushed a commit
that referenced
this pull request
Sep 15, 2026
…6548) ## Summary Stacked on top of #6528. `test_python_support_coverage` requires every PyDABs resource to have an `acceptance/bundle/python/<plural>-support/` fixture. `jobs` was the lone exception: it predates the `<plural>-support` convention and was carried in a `_LACKING` shrink-only allowlist ("covered across the suite instead"). This PR covers that gap by: - adding `jobs-support` test - removing the `_LACKING` allowlist ## Testing - `go test ./acceptance -run 'TestAccept/bundle/python/jobs-support'` passes without `-update` across all four variants (both engines × both wheel versions) — deterministic. - `test_python_support_coverage` passes for all 23 resources with no exceptions. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
pushed a commit
that referenced
this pull request
Sep 15, 2026
…6553) Stacked on #6548. ## Changes Enables PyDABs codegen to model the SDK `time.Time` type, which unblocks generating `resources.Secret` (its `expire_time` field is a `*time.Time`) and drops it from the codegen denylist. `time.Time` is mapped to Python `str` — an RFC3339 timestamp string. This mirrors how the Go side already models the type at its own config boundary (`libs/dyn/convert/sdk_native_types.go` treats `time.Time` as a string), so a PyDABs value flows unchanged through the same Go normalization pipeline that `databricks.yml` uses. Regenerated output adds the `secrets` module and its wiring; the `databricks.bundles.core` public-API snapshot update is purely additive (`add_secret`, `secret_mutator`, `secrets`). ## Tests - New `acceptance/bundle/python/secrets-support/` fixture (required by `test_python_support_coverage`): loads a Secret from YAML and Python, runs a `secret_mutator` over both, and exercises `expire_time` (RFC3339 string) end to end. `value` is a default-less variable reference supplied at validate time, as the secret value validator requires; direct-engine only. Passes with and without `-update`. - `pydabs-test` 423 passed; codegen unit tests 37 passed. ## Notes - A changelog fragment (`.nextchanges/bundles/`) is still to be added. This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on top of #6528.
test_python_support_coveragerequires every PyDABs resource to have anacceptance/bundle/python/<plural>-support/fixture.jobswas the lone exception: it predates the<plural>-supportconvention and was carried in a_LACKINGshrink-only allowlist ("covered across the suite instead").This PR covers that gap by:
jobs-supporttest_LACKINGallowlistTesting
go test ./acceptance -run 'TestAccept/bundle/python/jobs-support'passes without-updateacross all four variants (both engines × both wheel versions) — deterministic.test_python_support_coveragepasses for all 23 resources with no exceptions.This pull request and its description were written by Isaac.