acceptance: normalize plan_version in recorded plans via test repl - #6549
Merged
Merged
Conversation
Adds test.toml repls that replace the plan_version value with [PLAN_VERSION] in recorded plan output (both the JSON and gron forms). Bumping currentPlanVersion then only touches the two repl lines instead of churning every recorded plan golden. Co-authored-by: Isaac <no-reply@databricks.com>
shreyas-goenka
marked this pull request as ready for review
September 7, 2026 13:21
denik
approved these changes
Sep 7, 2026
Collaborator
Integration test reportCommit: 086f909
13 interesting tests: 13 flaky
Top 50 slowest tests (at least 2 minutes):
|
Collaborator
Integration test reportCommit: bc452d7
563 interesting tests: 514 MISS, 48 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
denik
added a commit
that referenced
this pull request
Sep 8, 2026
…_version repl #6549 normalized plan_version in every recorded plan, including this test's golden, and its version replaced the one this branch had regenerated. The golden then expected an email_notifications block the branch's testserver no longer produces at create. Regenerated, so it carries both: main's [PLAN_VERSION] repl and this branch's create behaviour. Co-authored-by: Isaac
denik
added a commit
that referenced
this pull request
Sep 11, 2026
…_version repl #6549 normalized plan_version in every recorded plan, including this test's golden, and its version replaced the one this branch had regenerated. The golden then expected an email_notifications block the branch's testserver no longer produces at create. Regenerated, so it carries both: main's [PLAN_VERSION] repl and this branch's create behaviour. Co-authored-by: Isaac
denik
added a commit
that referenced
this pull request
Sep 11, 2026
…_version repl #6549 normalized plan_version in every recorded plan, including this test's golden, and its version replaced the one this branch had regenerated. The golden then expected an email_notifications block the branch's testserver no longer produces at create. Regenerated, so it carries both: main's [PLAN_VERSION] repl and this branch's create behaviour. Co-authored-by: Isaac
denik
added a commit
that referenced
this pull request
Sep 11, 2026
…_version repl #6549 normalized plan_version in every recorded plan, including this test's golden, and its version replaced the one this branch had regenerated. The golden then expected an email_notifications block the branch's testserver no longer produces at create. Regenerated, so it carries both: main's [PLAN_VERSION] repl and this branch's create behaviour. Co-authored-by: Isaac
denik
added a commit
that referenced
this pull request
Sep 15, 2026
…_version repl #6549 normalized plan_version in every recorded plan, including this test's golden, and its version replaced the one this branch had regenerated. The golden then expected an email_notifications block the branch's testserver no longer produces at create. Regenerated, so it carries both: main's [PLAN_VERSION] repl and this branch's create behaviour. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a plan version repl to make the diff for #6094 smaller.