Skip to content

dms: allow "bundle destroy" regarding if configuration matches state - #6724

Open
denik wants to merge 20 commits into
mainfrom
denik/destroy-always
Open

denik wants to merge 20 commits into
mainfrom
denik/destroy-always

Conversation

@denik

@denik denik commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Changes

"bundle destroy" will now always work. Other commands (plan/deploy) still error if state "deployment_history" feature does not match requested in config.

Why

It makes it easier if destroy always works and fixes our own clean up procedure which relies on destroy over fabricated config.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: ee1feee

Run: 35229536420

Env ✅​pass 🙈​skip Time
✅​ aws linux 280 16 4:29
✅​ aws windows 282 14 5:35
✅​ azure linux 279 16 4:10
✅​ azure windows 281 14 4:05
✅​ gcp linux 280 16 4:39
✅​ gcp windows 282 14 4:04
Top 3 slowest tests (at least 2 minutes):
duration env testname
5:11 aws windows TestAccept
3:43 azure windows TestAccept
3:40 gcp windows TestAccept

@denik denik changed the title bundle: Make destroy use deployment history from state bundle: Use deployment history from state Sep 17, 2026
@denik denik changed the title bundle: Use deployment history from state dms: allow "bundle destroy" regarding if configuration matches state Sep 17, 2026
@denik
denik marked this pull request as ready for review September 17, 2026 13:42
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Approval status: pending

/acceptance/bundle/ - needs approval

6 files changed
Suggested: @shreyas-goenka
Also eligible: @janniklasrose, @pietern, @andrewnester, @lennartkats-db, @anton-107

/bundle/ - needs approval

4 files changed
Suggested: @shreyas-goenka
Also eligible: @janniklasrose, @pietern, @andrewnester, @lennartkats-db, @anton-107

/cmd/apps/ - needs approval

Files: cmd/apps/import.go
Suggested: @MarioCadenas
Also eligible: @fjakobs, @Shridhad, @atilafassina, @keugenek, @igrekun, @pkosiec, @pffigueiredo, @ditadi, @calvarjorge

/cmd/bundle/ - needs approval

6 files changed
Suggested: @shreyas-goenka
Also eligible: @janniklasrose, @pietern, @andrewnester, @lennartkats-db, @anton-107

Any maintainer (@andrewnester, @anton-107, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants