Repository navigation
Add support for building dlib on Windows ARM64 - #3164
Merged
Merged
Conversation
MSVC aliases NEON vector types, so removing the float-to-integer conversion operator makes simd4i construction copy floating-point bits into integer lanes. Add explicit numeric construction and assignment, and enable raw conversion overloads only when the underlying vector types differ. Use standard alignas(16) instead of compiler-specific alignment guards. Keep mixed float/integer arithmetic and existing x86 SIMD behavior intact. Select SIMD options using the MSVC compiler's target architecture rather than the host processor. Select the Python extension architecture through sysconfig.get_platform(), preserving x64 builds when Python runs under emulation on ARM64 Windows. Add conversion, mixed-arithmetic, image-resizing, Python architecture, and CMake target-selection regressions. Add a Windows ARM64 C++ CI job for SIMD and FHOG, and select Python 3.13 for the Windows Python jobs. Validation passed for native scalar/SSE2/AVX2, GCC ARM64 under QEMU, Clang NEON with MSVC compatibility macros, and a model of MSVC's aliased vector types under ASan/UBSan. Python and CMake target-selection tests also pass. Native MSVC ARM64 verification remains pending. An existing ARM image filtering tolerance failure reproduces on the original PR and is unchanged.
Owner
|
Thanks for the PR. I made some adjustments. Does it still work for you? |
Contributor
Author
|
Hi @davisking |
Owner
|
Cool, thanks for the PR :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: