Skip to content

ci: update the deprecated CodeQL action and checkout - #1639

Closed
DiegoDAF wants to merge 1 commit into
dbcli:mainfrom
DiegoDAF:upstream/codeql-v4
Closed

DiegoDAF wants to merge 1 commit into
dbcli:mainfrom
DiegoDAF:upstream/codeql-v4

Conversation

@DiegoDAF

Copy link
Copy Markdown
Contributor

GitHub annotates every CodeQL run on this repository with two notices, visible on any recent run of the workflow:

CodeQL Action major versions v1 and v2 have been deprecated. Please update all occurrences of the CodeQL Action in your workflow files to v3.

Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v3, github/codeql-action/analyze@v2, ...

The first is reported at failure level, so the workflow is already being flagged even though the analysis itself succeeds.

This moves github/codeql-action from v2 to v4 and actions/checkout from v3 to v5. Nothing else changes: same trigger, same python matrix and the same +security-and-quality query suite.

I ran the same change on my fork first and the CodeQL workflow comes back green with both annotations gone.

GitHub annotates every CodeQL run on this repository with two notices:

  CodeQL Action major versions v1 and v2 have been deprecated.
  Please update all occurrences of the CodeQL Action in your workflow
  files to v3.

  Node.js 20 is deprecated. The following actions target Node.js 20 but
  are being forced to run on Node.js 24: actions/checkout@v3,
  github/codeql-action/analyze@v2, ...

The first one is reported at failure level, so the workflow is already
being flagged. Moving codeql-action to v4 and checkout to v5 clears
both. No other change: the query suite and the matrix stay as they are.
DiegoDAF added a commit to DiegoDAF/pgcli.daf that referenced this pull request Sep 17, 2026
dbcli#1639 (CodeQL) and dbcli#1640 (sqlparse floor) are open. The two remaining
branches are written and tested, waiting for room in the queue.

Upcoming had grown to 84 items, and three of its sections were stating
things that stopped being true weeks ago: that four merged PRs were
still open, that the SQL_ASCII work was undecided, and that
$XDG_STATE_HOME was not done. Everything moved down to its date, nothing
was deleted.
@dbaty

dbaty commented Sep 21, 2026

Copy link
Copy Markdown
Member

I did the same (and some more) in a separate pull request: #1641.

@dbaty dbaty closed this Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants