fix: clarify ForceEndTurn deployment behavior - #788
Open
GregHolmes wants to merge 1 commit into
Open
GregHolmes wants to merge 1 commit into
GregHolmes wants to merge 1 commit into
Conversation
GregHolmes
requested review from
deepgram-kiley and
dg-coreylweathers
as code owners
September 14, 2026 12:19
Contributor
|
dg-coreylweathers
requested changes
Oct 1, 2026
dg-coreylweathers
left a comment
dg-coreylweathers
left a comment
Contributor
There was a problem hiding this comment.
What this PR does
Changes the ForceEndTurn examples and the conversational-STT skill file to say the control is available on Deepgram-hosted deployments including EU and AU (self-hosted depends on the release), makes the Voice Agent example fail fast on FORCE_END_TURN_UNSUPPORTED, and edits the manual-patch ledger.
What I checked
- Is the availability claim true? Yes: the repo's own
tests/manual/listen/v2/force_end_turn/main.pypassed all four steps withtrigger: manualagainstapi.deepgram.com,api.eu.deepgram.com, andapi.au.deepgram.com. - Is
FORCE_END_TURN_UNSUPPORTEDreal? Yes, it is the Voice Agent warning for a non-Flux listen provider (deepgram-docsschemas.agent.v1.yml:220), and both Warning and Error carry.code/.description. - Gates in Docker: mypy clean, ruff clean on changed files, pytest 1034 passed.
Blocking
- The
AGENTS.md/.fernignorehunk forlisten_v2eot_threshold.pyandrequests/deepgram_listen_provider_v2.pyis stale: main'sAGENTS.md:85already says Fern emits that description natively as of the 2026-09-23 regen and the files were unfrozen, so main's.fernignoreno longer lists them. The branch is also CONFLICTING. Fix: rebase onto main and drop that hunk entirely; keep only the StrictInt unfreeze-condition change.
Should-fix
- "Self-hosted availability depends on the deployed release" (
examples/16:24-25,SKILL.md:94) omits the switch. deepgram-docs says it needslisten_v2_force_end_turn = trueunder[features]on the 2026-09-15 release or later. Say that. tests/manual/listen/v2/force_end_turn/main.py:24-27,174andasync.py:8,115still say "gated per deployment" / "not enabled on this deployment"; align them with the new sentence.
Nit: examples/32:94-104, the trailing rejected-check can raise after agent_finished is set; fine if intended, worth a comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation