Skip to content

fix(deps): bump deepnote-python-lsp-server to 1.13.1.1 - #132

Merged
mfranczel merged 2 commits into
mainfrom
michal/bump-python-lsp-server-1.13.1.1
Oct 8, 2026
Merged

mfranczel merged 2 commits into
mainfrom
michal/bump-python-lsp-server-1.13.1.1

Conversation

@mfranczel

@mfranczel mfranczel commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Bumps deepnote-python-lsp-server from 1.13.1rc2 to 1.13.1.1, which fixes the language server on Python 3.14.

On 3.14, the server crashed as soon as a client connected in TCP mode (the mode Deepnote uses):

TypeError: PythonLSPServer.init() got multiple values for argument 'check_parent_process'

The fix is cherry-picked from upstream python-lsp/python-lsp-server#690. It only changes behaviour on Python 3.14+.

Changes

  • pyproject.toml: deepnote-python-lsp-server==1.13.1rc2 → ==1.13.1.1 (server extra)
  • poetry.lock: only the deepnote-python-lsp-server entry and content-hash change

Lock file note

  • poetry check --lock passes (Poetry 2.2.0, same as the lock header)
  • Wheel and sdist sha256 hashes match PyPI
  • 1.13.1.1 declares the same dependencies as 1.13.1rc2, so nothing else in the lock changes

Testing

Tested in the python-lsp-server fork:

  • Test suite on Python 3.14 and 3.9: 188 passed, 18 skipped. 1 teardown error in test_missing_message, which also fails on develop and on 3.11, so it isn't caused by this change.
  • On 3.14, pylsp --tcp authenticates and answers initialize. Before the fix it crashed on connect.

Resolves BLU-6474

Summary by CodeRabbit

  • Chores
    • Updated the server setup to use the released version of its language server instead of a prerelease. No user-facing features or behavior have changed. This update affects the server configuration only; the existing product experience remains unchanged.

Fixes the language server crashing on client connect in TCP mode on
Python 3.14 (upstream python-lsp/python-lsp-server#690).

The lock update covers only this package. A full `poetry lock` would
also upgrade many locked dependencies for Python < 3.14.
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 39fb1807-184f-4665-b3ce-92cabc74745c
📥 Commits

Reviewing files that changed from the base of the PR and between 5e182db and 718eb71.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The server extra now pins deepnote-python-lsp-server to version 1.13.1.1 instead of 1.13.1rc2.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: m1so

Merge Risk: ⚪ Minimal · up to 718eb

No actionable issue is identified with the server dependency update; it is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Updates Docs ✅ Passed PASS: This pull request is a dependency-only compatibility fix. The authoritative diff changes only pyproject.toml and poetry.lock; it does not implement a new feature or change a documented user-…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating deepnote-python-lsp-server to version 1.13.1.1.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

📦 Python package built successfully!

  • Version: 2.8.0.dev4+6f00217
  • Wheel: deepnote_toolkit-2.8.0.dev4+6f00217-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/2.8.0.dev4%2B6f00217/deepnote_toolkit-2.8.0.dev4%2B6f00217-py3-none-any.whl"

@linear-code

linear-code Bot commented Oct 7, 2026

Copy link
Copy Markdown

BLU-6474

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 7, 2026
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.26%. Comparing base (abf4243) to head (718eb71).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files         115      115           
  Lines        6589     6589           
  Branches      961      961           
=======================================
  Hits         5091     5091           
  Misses       1186     1186           
  Partials      312      312           
Flag Coverage Δ
combined 77.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@deepnote-bot

deepnote-bot commented Oct 7, 2026 •

Copy link
Copy Markdown

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-132
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
⏰ Last deployed 2026-10-07 16:25:22 (UTC)
📜 Deployed commit 651d7b2c965e8a88e7b5aeabf81bcffd682134d3
🛠️ Toolkit version 6f00217

…p-server-1.13.1.1

# Conflicts:
#	poetry.lock
@mfranczel
mfranczel requested a review from m1so October 7, 2026 16:12
@mfranczel
mfranczel marked this pull request as ready for review October 7, 2026 16:13
@mfranczel
mfranczel requested a review from a team as a code owner October 7, 2026 16:13
@mfranczel
mfranczel merged commit 4fa893b into main Oct 8, 2026
38 checks passed
@mfranczel
mfranczel deleted the michal/bump-python-lsp-server-1.13.1.1 branch October 8, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants