Repository navigation
fix(deps): bump deepnote-python-lsp-server to 1.13.1.1 - #132
Conversation
Fixes the language server crashing on client connect in TCP mode on Python 3.14 (upstream python-lsp/python-lsp-server#690). The lock update covers only this package. A full `poetry lock` would also upgrade many locked dependencies for Python < 3.14.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is identified with the server dependency update; it is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Comment |
|
📦 Python package built successfully!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 77.26% 77.26%
=======================================
Files 115 115
Lines 6589 6589
Branches 961 961
=======================================
Hits 5091 5091
Misses 1186 1186
Partials 312 312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
|
🚀 Review App Deployment Started
|
…p-server-1.13.1.1 # Conflicts: # poetry.lock
Summary
Bumps
deepnote-python-lsp-serverfrom1.13.1rc2to1.13.1.1, which fixes the language server on Python 3.14.On 3.14, the server crashed as soon as a client connected in TCP mode (the mode Deepnote uses):
TypeError: PythonLSPServer.init() got multiple values for argument 'check_parent_process'
The fix is cherry-picked from upstream python-lsp/python-lsp-server#690. It only changes behaviour on Python 3.14+.
Changes
pyproject.toml:deepnote-python-lsp-server==1.13.1rc2→==1.13.1.1(serverextra)poetry.lock: only thedeepnote-python-lsp-serverentry andcontent-hashchangeLock file note
poetry check --lockpasses (Poetry 2.2.0, same as the lock header)Testing
Tested in the
python-lsp-serverfork:test_missing_message, which also fails ondevelopand on 3.11, so it isn't caused by this change.pylsp --tcpauthenticates and answersinitialize. Before the fix it crashed on connect.Resolves BLU-6474
Summary by CodeRabbit