Repository navigation
feat!: move result type to the first type parameter - #6
Merged
Merged
Conversation
The result type is the type parameter that is set most often. As first
parameter it can be set without repeating the other defaults:
new Quaire<MyResult>({ items }).
BREAKING CHANGE: the type parameter order of Quaire is now
<Result, Item, Question, NavigationItem>, of QuaireBase
<Result, Question, NavigationItem> and of QuaireOptions
<Result, Item, NavigationItem>.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is accomplished by your PR?
The result type is now the first type parameter. TypeScript does not allow skipping leading type parameters, so before this change all defaults had to be repeated to set the result type.
New order:
Quaire<Result, Item, Question, NavigationItem>QuaireBase<Result, Question, NavigationItem>QuaireOptions<Result, Item, NavigationItem>extending-data-definitionexample are updatedresultoption without explicit type argumentsIs there something controversial in your PR?
Breaking change for subclasses with custom types (planned for 1.0):
Checklist
🤖 Generated with Claude Code