Repository navigation
fix(ci): preserve PR-only caller admission in main CI - #509
Conversation
Validation and user evaluation for signed head The new main-event regression failed before the repair on the two selected-but-intentionally-skipped reusable callers. It now passes. The real selector and unchanged required reducer also accept the actual native Both caller definitions exactly match their original admission, inputs, permissions and lack of prerequisites. They remain in global result aggregation. The called workflows retain their push, bot, fork and release-PR exclusions. A read-only independent audit found no other legitimate whole-caller skips among the remaining selectable reusable calls. All six affected contract entrypoints pass, including 43 real-source credential mutation controls, selector race tests, vet and deployment-only composition. The complete 14-command maintenance baseline, shell syntax, shellcheck and diff checks pass. The required reducer and its credential-boundary digest were not changed. The commit signature was verified successfully before pushing. Hosted and post-merge user evaluation is now complete. PR CI run 37393395416 passed at the signed reviewed head with 159 successful jobs and 76 intentional skips; current-head review 5422828570 is GREEN. PR #509 merged through the normal protected path as signed commit |
Code Coverage OverviewLanguages: Go, C# Go / code-coverage/testThe overall line coverage in commit cced150 in the C# / code-coverage/dotnetThe overall line coverage in commit cced150 in the Updated |
@coderabbitai full review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: cced1503031cd153a7cd83ffaeef74f4c581d76e
-
CodeRabbit: the current PR's included-review request was refused at 2026-10-06T01:34:43Z, with a 21-minute included-quota reset for this public repository. Direct quota artifact, freshly read; the no-gate guard returned ADMIT for this exact head. Recovery is the included allowance reset, not paid overage.
-
Codex: account-wide code-review usage limit at 2026-10-05T16:59:30Z, freshly verified from the direct provider artifact. Recovery is restored included review allowance; no paid credits or redundant request is used.
-
Cursor Bugbot: user/team usage or spend limit at 2026-10-03T22:35:03Z, freshly verified from the direct provider artifact. Recovery requires restored allowance or the team's limit decision; no paid overage is used.
I reviewed all five changed files against 8c0214ff944f615c35b122c4c8776151dfb561ce, with a separate independent current-head review of the complete diff. Both caller declarations restore their exact original admission, inputs and permissions, remain in global result aggregation, and retain the called workflows' event, actor, fork and release exclusions. Neither the reducer nor its credential-boundary digest changes.
The main-event regression demonstrates RED then GREEN. The actual failed native main result map passes the unchanged reducer with the repaired selection. All 82 unexpected selected-execution skips and all ten preserved-caller failure controls still fail. The 79-plus-three full scope, 31-plus-three deployment floor, inventory, fixture and documentation agree. All affected contracts, 43 credential mutations, race tests, vet and the complete 14-command maintenance baseline passed. Hosted CI 37393395416 passed at this exact head with 159 successful jobs and 76 intended skips.
Fresh direct reads found no review objects, no unresolved or hidden-page threads, no Codex comment findings, and no Bugbot check-run at this head. CodeRabbit's quota shell is not a review. No correctness, security or other actionable finding remains in the complete diff.
Verdict: no P0/P1 findings
Why
Main CI fails after an otherwise green merge because two reusable workflows intentionally skip outside pull requests. The test selector incorrectly treats those skips as missing execution.
What
Restores the two callers' original admission and retains their existing event, actor and fork exclusions. Their failures still fail CI, and every selected execution must succeed. Adds a main-event regression alongside the existing pull-request case and updates the documented coverage counts.
Fixes #508
Part of #475