Repository navigation
chore(data-products): deploy verified controller fixes - #4555
Conversation
Release evidence for ed8d317, based on efbd632:
Before queue entry, require settled current-head CI and substantive review. The production merge group must verify actual current deployments/pods/routes and public application behavior; this comment does not claim deployment. Rollback is the previous reviewed immutable chart/image pair, restored together through normal GitOps. |
@coderabbitai full review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
devantler
left a comment
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: ed8d317
Reviewed base: efbd632
Availability observed: 2026-10-06 04:52 UTC, using direct authenticated provider responses and the complete current-PR artifact intake.
- CodeRabbit: the current-head Platform request at 04:47:36 UTC returned a repository-specific included-review limit. Its summary, updated 04:47:51 UTC, names this exact base/head and three selected files, with a 47-minute reset (about 05:34:51 UTC). The quota status is a service response, not a review verdict.
- Codex: its authenticated account-wide usage-limit response, created/updated 04:40:17 UTC, remains unchanged on fresh read. No reset is stated; recovery requires account limits to reset or a maintainer account change. No paid credits are authorized.
- Cursor Bugbot: its authenticated user/team usage-limit response, created/updated 04:42:02 UTC, remains unchanged on fresh read. Recovery requires a user/team usage reset or an administrator change; no paid increase is authorized.
The complete current-PR intake contains four conversation comments, zero review objects and zero review threads, with no remaining pages. Its current-head check list contains no Bugbot run or provider finding. There is no hidden actionable review being discarded. All three lanes are currently unavailable, so the repository's local-review fallback applies without waiting for the quota window.
Correctness and security review:
- I reviewed the entire three-file diff. It keeps the Helm-managed controller, Harbour application and independent portable host on the same immutable image, and pins the matching chart digest. The release tag resolves to the actual merged controller source.
- Independent signature verification binds both artifacts to the expected issuer, repository, release ref, exact source commit and intended publishing workflow identities. The actual chart reports chart/app version 2.4.8 and supports the platform's Kubernetes version.
- I checked the effective rendered workloads, published-image smoke evidence and exact Flux-controller SDK install/upgrade post-renderer evidence. All three workloads retain two replicas, existing restrictive security settings, public UI origins and explicit grants. The disruption budgets still select their intended workloads.
- CRD, API/RBAC, persistence and routing contracts are unchanged. No adoption feature is enabled. The inactive HTTP-source schema adjustment rejects interpolation syntax. The update introduces no persistence migration.
- The ordinary rollback restores the previous reviewed immutable chart/image pair together; the existing merge-group restoration of current main remains intact. No deployment script or shared production control is changed.
- A separate independent read-only audit at this exact head reached the same clean verdict after its own artifact signature verification.
Limits: the two local KSail commands include skipped chart renders, which I do not count as complete render evidence; the independent controller-SDK guard actually pulled and rendered this chart. This review does not claim a deployed-runtime result. Hosted CI must settle at this head, and the production merge group must verify the actual rollout before merge.
Verdict: no P0/P1 findings
Ready for normal protected queue entry at ed8d317.
The production merge group must still establish actual current deployment/pod/route identities and public application behavior. Queue entry is not a deployed-runtime claim. |
Release v2.4.8 is actually deployed. This PR merged at Protected CI 37438356284 and production job 112188579333 succeeded for that exact merge-group commit. The deployed commit's three release pins match the independently verified image Post-deployment browser acceptance passed on both the catalogue and the independent host: two synthetic observation rows, one row when filtering Nordhavn, connected v2 interface, explicit presentation grants, light/dark propagation into the frame, query retention across theme changes and dark preference persistence after reload. Explicit Close hides the portable frame and removes its URL. Both frames retain the opaque Browser tooling could not deliver the attempted keyboard command and could not attach a new tab. Acceptance used native controls and the existing owned test tab; no manual keyboard or pixel/screen-reader result is claimed. Hosted browser regressions and published-image tests remain the separate automated evidence. This completes #4554. Feature/adoption gates remain unchanged. The managed Code Quality detail is still UNVERIFIED through its API; normal protected queue enforcement was used without a bypass. The separate ARC recovery in #4544 remains a named operational HOLD, so this controller delivery does not claim platform-wide health. |
Why
The platform is four patch releases behind the controller's completed reliability fixes, so users cannot benefit from those fixes yet.
What
Deploy the current reliability fixes across the registry, Harbour sample and independent product host. Keep the current product features and appearance settings.
Fixes #4554