Skip to content

chore (deps) : update controller-runtime to v0.25.1 - #1706

Open
rohanKanojia wants to merge 2 commits into
devfile:mainfrom
rohankanojia-forks:pr/chore-update-controller-runtime
Open

rohanKanojia wants to merge 2 commits into
devfile:mainfrom
rohankanojia-forks:pr/chore-update-controller-runtime

Conversation

@rohanKanojia

@rohanKanojia rohanKanojia commented Sep 16, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Updates controller-runtime from v0.24.1 to v0.25.1, including required Kubernetes dependencies to v0.37.0.
Regenerates CRD, deployment, and OLM bundle manifests in a separate commit.

Assisted-by: Codex
Signed-off-by: Rohan Kumar rohaan@redhat.com

What issues does this PR fix or reference?

None.

Is it tested? How?

  • make test passed, including unit tests, all 43 controller specs, formatting, and vet checks.
  • make generate_all completed successfully.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Summary by CodeRabbit

  • New Features

    • Added support for configuring HTTP probe protocols and gRPC probe connection modes.
    • Added volume mount options such as noexec, nodev, and nosuid.
    • Added volume permission settings, including empty-directory modes and ownership fields for supported volume sources.
    • Added support for specifying SELinux mount behavior and expanded volume configuration options.
  • Documentation

    • Clarified ConfigMap key behavior, mount paths, data sources, and probe defaults across Kubernetes and OpenShift schemas.

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 8c66b94a-2c70-4e56-ad18-8139d6378439

📥 Commits

Reviewing files that changed from the base of the PR and between 45cd9c3 and 2987934.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (11)
  • deploy/bundle/manifests/controller.devfile.io_devworkspaceoperatorconfigs.yaml
  • deploy/bundle/manifests/controller.devfile.io_devworkspaceroutings.yaml
  • deploy/deployment/kubernetes/combined.yaml
  • deploy/deployment/kubernetes/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml
  • deploy/deployment/kubernetes/objects/devworkspaceroutings.controller.devfile.io.CustomResourceDefinition.yaml
  • deploy/deployment/openshift/combined.yaml
  • deploy/deployment/openshift/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml
  • deploy/deployment/openshift/objects/devworkspaceroutings.controller.devfile.io.CustomResourceDefinition.yaml
  • deploy/templates/crd/bases/controller.devfile.io_devworkspaceoperatorconfigs.yaml
  • deploy/templates/crd/bases/controller.devfile.io_devworkspaceroutings.yaml
  • go.mod

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request regenerates Kubernetes and OpenShift CRD schemas, adds newer probe and volume fields, refreshes schema descriptions, updates combined manifests, and upgrades Kubernetes-related Go dependencies.

Changes

Kubernetes schema refresh

Layer / File(s) Summary
DevWorkspaceOperatorConfig schemas
deploy/templates/crd/bases/*devworkspaceoperatorconfigs*, deploy/deployment/*/objects/*devworkspaceoperatorconfigs*, deploy/bundle/manifests/*devworkspaceoperatorconfigs*
HTTP probes add protocol; gRPC probes add mode; volume mounts add bindMountOptions; ConfigMap and SELinux descriptions are updated.
DevWorkspaceRouting schemas
deploy/templates/crd/bases/*devworkspaceroutings*, deploy/deployment/*/objects/*devworkspaceroutings*, deploy/bundle/manifests/*devworkspaceroutings*
Probe, volume mount, volume ownership, emptyDir, and data-source schemas are expanded or reworded.
Combined manifests
deploy/deployment/kubernetes/combined.yaml, deploy/deployment/openshift/combined.yaml
The combined Kubernetes and OpenShift manifests mirror the refreshed schema fields and descriptions.
Go dependency updates
go.mod
Kubernetes libraries, controller-runtime, Prometheus, and indirect dependencies are upgraded. Two indirect dependencies are removed and go-openapi/swag is split into submodules.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 29879

The schema and dependency refresh has no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: updating controller-runtime to v0.25.1 as part of the dependency upgrade. It is concise and related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rohanKanojia rohanKanojia self-assigned this Sep 16, 2026
@rohanKanojia rohanKanojia moved this from Blocked to 🚧 In Progress in Eclipse Che Team B Backlog Sep 16, 2026
@rohanKanojia
rohanKanojia force-pushed the pr/chore-update-controller-runtime branch from f9be203 to 1d2fbc7 Compare September 16, 2026 15:45
Assisted-by: Codex
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…de to v0.25.1

Assisted-by: Codex
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia
rohanKanojia force-pushed the pr/chore-update-controller-runtime branch from 1d2fbc7 to 2987934 Compare September 17, 2026 05:24
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia
rohanKanojia marked this pull request as ready for review September 17, 2026 05:31
@rohanKanojia rohanKanojia moved this from 🚧 In Progress to Ready for Review in Eclipse Che Team B Backlog Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant