Repository navigation
Disallow DVLE-Specific Directives When Using .nodvle #32
Description
Activity
This is a good point. However, I think it would be more intuitive to add a way to actually instantiate these constants in all dvles that make use of procedures contained in the non-dvle pica source code file.
It would be convenient for sure, but performance on shader swaps would be slightly worse than using shared uniforms.
Actually, that's true for any constant, is it not? At least under C3D, since I believe it re-sends all constants on a shader load.
There usually aren't that many constants per DVLE. Rewriting shader code memory (when using shaders from different shbins) is much more expensive. I'd say it's not really a concern.
Bug Report
What's the issue you encountered?
Certain directives perform no function, or worse, enable undefined behavior when used with the .
nodvledirective. A compilation error should be raised in these circumstances.Affected directives include:
.constdirectives.setdirectives.entryHow can the issue be reproduced?
Compile a group of shader files, with at least one file containing the
.nodvledirective and one or more of the aforementioned directives. This program will compile normally.Environment?
Additional context?
According to the README, constants are never shared between DVLEs. Despite this, they can be declared inside of shader source files containing the
.nodvledirective. These constants will not have a defined value, as constants are only ever initialized when a DVLE is selected, thus causing undefined behavior that can be very difficult to trace if a developer is unfamiliar with their function.The same applies to the
.setdirectives, which are also only ever executed in files with DVLEs.The
.entrydirective, while harmless, has no function within a.nodvlefile.