Skip to content

docs: point two Wall comments at code that still exists - #673

Merged
nedtwigg merged 1 commit into
mainfrom
fix/stale-wall-comment-pointers
Sep 16, 2026
Merged

nedtwigg merged 1 commit into
mainfrom
fix/stale-wall-comment-pointers

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

Two comments in lib/src/components/wall/ point at functions that no longer
exist, so a reader following either pointer finds nothing.

  • workspace-boot-plans.ts names unwindAdoption as the caller that unwinds a
    mount before the store prunes its parked plan. Last night's Deliver pane alerts reliably with workspace-specific notification settings #667 folded that
    function into discardArrival, which is the caller today
    (standalone/src/workspace-move.ts).
  • lath-wall-engine.ts cites addTerminalPanel twice, once for the
    default-shell priming seed's fresh flag drives and once for the
    autoEdge split. That was a local helper inside the dockview-era Pond.tsx,
    removed in f843b21 (April). Both clauses now describe the live path — the
    Wall's own seed effect, and the null add position — instead of naming a
    symbol.

Comment-only, so there is no regression test: nothing executes differently, and
the defect is that a reader's grep comes back empty. grep -rn 'addTerminalPanel\|unwindAdoption' over the repo returns nothing after this
change.

Local verification was partial: pnpm is not on this runner's PATH, so the
package tests did not run here. The dependency-free repo lints
(spec-lint, loopback-lint, public-docs-lint) pass, and CI covers the
rest. spec-lint does report two pre-existing failures on this runner —
standalone/sidecar/node_modules "path does not exist" from
security-supply-chain.md and standalone.md — which are an artifact of the
uninstalled tree, not of this branch.

`unwindAdoption` was renamed `discardArrival` in 9a2bce2; `addTerminalPanel` was a local helper in the dockview-era Pond.tsx, gone since f843b21.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: e991dc6
Status: ✅  Deploy successful!
Preview URL: https://2de41043.mouseterm.pages.dev
Branch Preview URL: https://fix-stale-wall-comment-point.mouseterm.pages.dev

View logs

@nedtwigg
nedtwigg marked this pull request as ready for review September 16, 2026 20:25
@nedtwigg
nedtwigg merged commit e9b3d7a into main Sep 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants