docs: point two Wall comments at code that still exists - #673
Merged
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
e991dc6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2de41043.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-stale-wall-comment-point.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two comments in
lib/src/components/wall/point at functions that no longerexist, so a reader following either pointer finds nothing.
workspace-boot-plans.tsnamesunwindAdoptionas the caller that unwinds amount before the store prunes its parked plan. Last night's Deliver pane alerts reliably with workspace-specific notification settings #667 folded that
function into
discardArrival, which is the caller today(
standalone/src/workspace-move.ts).lath-wall-engine.tscitesaddTerminalPaneltwice, once for thedefault-shell priming
seed'sfreshflag drives and once for theautoEdgesplit. That was a local helper inside the dockview-eraPond.tsx,removed in f843b21 (April). Both clauses now describe the live path — the
Wall's own seed effect, and the
nulladd position — instead of naming asymbol.
Comment-only, so there is no regression test: nothing executes differently, and
the defect is that a reader's grep comes back empty.
grep -rn 'addTerminalPanel\|unwindAdoption'over the repo returns nothing after thischange.
Local verification was partial:
pnpmis not on this runner's PATH, so thepackage tests did not run here. The dependency-free repo lints
(
spec-lint,loopback-lint,public-docs-lint) pass, and CI covers therest.
spec-lintdoes report two pre-existing failures on this runner —standalone/sidecar/node_modules"path does not exist" fromsecurity-supply-chain.mdandstandalone.md— which are an artifact of theuninstalled tree, not of this branch.