Conversation
Goooler
added this pull request to stack #3076
September 15, 2026 10:25
Goooler
force-pushed
the
g/20260908/windows-on-arm
branch
from
September 15, 2026 10:31
efb2992 to
3d810b4
Compare
This should speed up builds.
Goooler
force-pushed
the
g/20260908/windows-on-arm
branch
2 times, most recently
from
September 15, 2026 11:31
1451bc8 to
fc56d64
Compare
NpmTestsWithoutNpmInstallationTest
Goooler
force-pushed
the
g/20260908/windows-on-arm
branch
from
September 15, 2026 13:21
20322e7 to
6796ffe
Compare
NpmTestsWithoutNpmInstallationTest-----
Bump Node to v22.14.0 in NpmTestsWithDynamicallyInstalledNpmInstallationTest
Fixes 404 download failure on Windows ARM64 runners when frontend-maven-plugin attempts to download Node 18 (which has no official win-arm64 binaries on nodejs.org):
```
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.11.3:install-node-and-npm (default-cli) on project spotless-maven-plugin-tests: Could not download Node.js: Got error code 404 from the server. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.11.3:install-node-and-npm (default-cli) on project spotless-maven-plugin-tests: Could not download Node.js: Got error code 404 from the server.
Caused by: org.apache.maven.plugin.MojoFailureException: Could not download Node.js: Got error code 404 from the server.
at com.github.eirslett.maven.plugins.frontend.mojo.MojoUtils.toMojoFailureException(MojoUtils.java:28)
at com.github.eirslett.maven.plugins.frontend.mojo.AbstractFrontendMojo.execute(AbstractFrontendMojo.java:103)
```
-----
Bump Node to 22.14.0 and npm to 10.9.2 in NpmTestsWithoutNpmInstallationTest
Node.js official distribution did not provide Windows ARM64 (win-arm64.zip) prebuilt binaries for Node 18.x, causing download failures on Windows on ARM runners:
```
Could not determine the dependencies of task ':nodeSetup'.
> Failed to query the value of task ':nodeSetup' property 'nodeArchiveFile'.
> Could not resolve all files for configuration ':detachedConfiguration1'.
> Could not find org.nodejs:node:18.16.1.
Searched in the following locations:
- https://nodejs.org/dist/v18.16.1/node-v18.16.1-win-arm64.zip
```
-----
Bump gradle-node-plugin to 7.1.0 in NpmTestsWithoutNpmInstallationTest
Fixes configuration cache failure on Linux ARM runners where gradle-node-plugin 3.5.1 attempted to run `uname -m` during configuration time:
```
Caused by: org.gradle.api.InvalidUserCodeException: Starting an external process 'uname -m' during configuration time is unsupported.
at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onExternalProcessStarted(ConfigurationCacheProblemsListener.kt:87)
at org.gradle.configurationcache.InstrumentedInputAccessListener.externalProcessStarted(InstrumentedInputAccessListener.kt:110)
at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:501)
at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:509)
at org.gradle.internal.classpath.Instrumented.start(Instrumented.java:363)
at com.github.gradle.node.util.KotlinUtilsKt.execute(KotlinUtils.kt:14)
```
Goooler
force-pushed
the
g/20260908/windows-on-arm
branch
from
September 15, 2026 13:29
6796ffe to
354985d
Compare
Member
|
I'm not so sure about this ARM change. If it makes a big difference, great, but if it's only a small change then it makes our CI less similar to most non-Apple developer machines. Whether you include this or not, please merge the rest of your stack if you're happy with it! Little PRs are coming in and I'm afraid to merge them and screw up this nice tower of great PRs you've got going on here. I'm very eager to publish soon so that we can test all these buildscript changes which have landed. |
An error occurred while trying to automatically change base from
g/20260908/java-25-26
to
main
September 16, 2026 12:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should speed up builds.