Document the legacy plugin id removal - #3093
Merged
Merged
Conversation
#3086 stopped publishing the marker for the legacy `com.diffplug.gradle.spotless` id and added a historical capability, both of which can break a consumer's build. Neither was in the changelog. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Drops the capability entry: the declared capability com.diffplug.gradle.spotless:spotless-plugin-gradle never existed as a published module, so it conflicts with nothing and there is nothing for users to act on. The real former coordinates were com.diffplug.gradle.spotless:spotless (1.2.0 through 2.4.1). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
|
Or we can revert b667bcb and still try to publish the legacy plugin coordinate. The removal could be landed in the next major. I removed it due to the main reason for the blocker of 403 error, but the real cause might be the |
Member
Author
|
I think it's good that it has been removed. We've been generating a very loud warning for years now. The real breaking change happened a long time ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3086 stopped publishing the plugin marker for the legacy
com.diffplug.gradle.spotlessid, and thenext release ships that change without a changelog entry. This adds one.
The marker has been published for every release from 1.1 through 8.10.2, so
plugins { id 'com.diffplug.gradle.spotless' version '<next>' }will fail with "was not found" forthe first time in the project's history. The redirect class is still on the classpath and still
prints its migration message when the id is applied from an existing classpath, so only resolution
through the plugin portal changes.
Not documented, deliberately: #3086 also declares a historical capability
com.diffplug.gradle.spotless:spotless-plugin-gradle. No module by that name was ever published —the former coordinates were
com.diffplug.gradle.spotless:spotless(1.2.0 through 2.4.1) — so thedeclaration conflicts with nothing and there is nothing for users to act on. Worth fixing in the
build separately, or dropping.
Found while reviewing everything merged since 8.10.2, the same review that caught #3089.
🤖 Generated with Claude Code