Skip to content

Add SSE to i386 builds - #1684

Merged
tianon merged 1 commit into
docker-library:masterfrom
infosiftr:i386
Sep 10, 2026
Merged

Add SSE to i386 builds#1684
tianon merged 1 commit into
docker-library:masterfrom
infosiftr:i386

Conversation

@yosifkit

@yosifkit yosifkit commented Sep 4, 2026

Copy link
Copy Markdown
Member

Fixes #1683 for 8.6-rc and 8.5.10. Applied to all versions, because it "should" make it faster.

xmm0 - xmm7 are the SSE registers.

Where the xmm* registers were added to PHP: php/php-src@8c96f53d91c#diff-62b1ac3b4be89a1968b7a4b5d8eb9e90ea7812e1c6bbf4bc29a2a48b3e7c6c06R117

Build error:

/usr/src/php/ext/opcache/jit/tls/zend_jit_tls_x86.c: In function 'zend_jit_resolve_tsrm_ls_cache_offsets':
/usr/src/php/ext/opcache/jit/tls/zend_jit_tls_x86.c:95:9: error: the register 'xmm7' cannot be clobbered in 'asm' for the current target
   95 |         __asm__ __volatile__(
      |         ^~~~~~~
make: *** [Makefile:1728: ext/opcache/jit/tls/zend_jit_tls_x86.lo] Error 1

🤔 I think this should also be applied to the Alpine images. ❓

@tianon tianon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I think this should also be applied to the Alpine images. ❓

Agreed, seems sane to me.

@tianon tianon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping maybe we could be even more explicit with -march=pentium4, and we can, but that only implies -msse2 and apparently -mfpmath will still be 387.

@tianon
tianon merged commit 1fec3ee into docker-library:master Sep 10, 2026
86 checks passed
@tianon
tianon deleted the i386 branch September 10, 2026 21:23
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Sep 10, 2026
Changes:

- docker-library/php@1fec3eef: Add sse to i386 builds (docker-library/php#1684)
- docker-library/php@b9ae6b9d: Update 8.4-rc to 8.4.26RC1
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Sep 11, 2026
Changes:

- docker-library/php@158821b2: Update 8.6-rc to 8.6.0beta3
- docker-library/php@1fec3eef: Add sse to i386 builds (docker-library/php#1684)
- docker-library/php@b9ae6b9d: Update 8.4-rc to 8.4.26RC1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some Debian images missing for 8.5.10-zts

2 participants